Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum Value: enum type should be declared in it's own table #5322

Open
7 tasks
davidwatkins73 opened this issue Mar 4, 2021 · 2 comments
Open
7 tasks

Enum Value: enum type should be declared in it's own table #5322

davidwatkins73 opened this issue Mar 4, 2021 · 2 comments
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database good first issue An issue suitable for new project collaborators

Comments

@davidwatkins73
Copy link
Member

davidwatkins73 commented Mar 4, 2021 •
edited

This would allow us to capture some additional data such as is_hardcoded

name desc
enum_type camel case name of type (i.e. BookmarkKind
is_hardcoded can values be added via config or is it tied to a java enum (and therefore fixed)
description for admin gui
  • create table
  • fk to enum_value ?
  • pre-populate via liquibase scripts
  • admin gui (initially just viz)
  • documentation
  • impact analysis of switching to id keys for the ref from enum value to this new table
    • impl if appropriate
@davidwatkins73 davidwatkins73 added this to the todo - Current (1.31) milestone Mar 4, 2021
@davidwatkins73 davidwatkins73 added DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database small change Should be a simple, low complexity issue good first issue An issue suitable for new project collaborators and removed small change Should be a simple, low complexity issue labels Mar 4, 2021
@davidwatkins73 davidwatkins73 changed the title Enum Value: enum type should have it's own table which enum value references Enum Value: enum type should be declared in it's own table Mar 4, 2021
@mcleo-d
Copy link
Member

mcleo-d commented May 10, 2021

Hi @davidwatkins73 - Is there anything I can do to help pull contributors into this issue. It would be great to get into closed and over the line?

Speak soon,

James 🚀

@davidwatkins73
Copy link
Member Author

It's a fairly involved issue, though reasonably straight forward. We have some videos on ddl changes [1] to help get people started. Perhaps this should be marked as something like a 'good pairing issue' as it's something we'd be willing to work closely with people on - rather than being something a newcomer would be able to pick up.

[1] - Schema modifications screencast

@davidwatkins73 davidwatkins73 removed this from the next : 1.46 milestone Sep 5, 2022
@msagi msagi mentioned this issue Feb 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database good first issue An issue suitable for new project collaborators
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidwatkins73 @mcleo-d