Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IntLiteral to WholeNumberLiteral #399

Closed
AttilaMihaly opened this issue Mar 22, 2021 · 0 comments
Closed

Rename IntLiteral to WholeNumberLiteral #399

AttilaMihaly opened this issue Mar 22, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AttilaMihaly
Copy link
Member

The name IntLiteral suggests that the value is of Int type which is not the case. IntLiteral has the type of number which can either be an Int or Float currently (may be extended in the future). Calling it NumberLiteral would be too broad though as it can only represent whole numbers. Hence we should call it WholeNumberLiteral.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AttilaMihaly