Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionAppAuthenticator in core starter is not conditional #491

Closed
yinan-symphony opened this issue Apr 15, 2021 · 0 comments · Fixed by #616
Closed

ExtensionAppAuthenticator in core starter is not conditional #491

yinan-symphony opened this issue Apr 15, 2021 · 0 comments · Fixed by #616
Labels
good first issue Good for newcomers [type] enhancement New feature or request

Comments

@yinan-symphony
Copy link
Contributor

yinan-symphony commented Apr 15, 2021

Feature Request

Make ExtensionAppAuthenticator bean and OboAuthenticator bean conditional.

Description of Problem:

ExtensionAppAuthenticator bean defined in BdkOboServiceConfig is not conditional on missing, as the other beans, while it is the same for OboAuthenticator. This forbidden users to inject their own implementation for them ( we are working for a MT solution, so need us to have an extension app authenticator being able to authenticate the extension app by the tenant id, so it could be injected in the current circle trust controller).

...please resist the temptation to describe your request in terms of a solution. Job Story form ("When [triggering condition], I want to [motivation/goal], so I can [outcome].") can help ensure you're expressing a problem statement.

Potential Solutions:

...clearly and concisely describe what you want to happen. Add any considered drawbacks.

... if you've considered alternatives, clearly and concisely describe those too.

@thibauult thibauult added [type] enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2021
thibauult pushed a commit that referenced this issue Jan 4, 2022
Make the ExtensionAppAuthenticator and OboAuthenticator conditional
on missing bean, so that the BDK application is able to choose to
provide the these customised beans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers [type] enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants