New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Red Hat OpenShift Container Platform Service Approval Accelerator #97
Conversation
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
</tr> | ||
|
||
</tr> | ||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i imagine this is intended as a "preview"? Or is it accidentally left in?
It'd be nicest to have a comment to remove this before the PR is merged instead of leaving it as a comment, since this interferes with the markdown preview side of things, making the doc quite hard to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, I actually converted the format to Asciidoc and submitted subsequent pull requests.
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
Updated Doc Links
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
Hi @J0EG - This is to confirm you have been added to the Red Hat CCLA and now need to update your local git settings so your commit records reflect the details be have at FINOS. I will reach out to your privately to align on these details. |
@@ -0,0 +1,560 @@ | |||
# Detailed Security Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this contain the same content as the asciidoc version? I skimmed it and it seems similar - if so we should delete one and keep one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good start. It would be even better if this document could be more opinionated in the configuration, take a look at the GKE equivalent for some guidance - for example around CMEK, encryption of etcd.d, workload isolation, certificates, etc.
hello there |
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.
Alternatively, use the slightly more complex If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request. Thanks once again for the contribution and understanding. cc @finos-admin |
@mcleo-d We will likely need to move this into the next sprint, we've made some progress regarding running probr against OpenShift and want to incorporate those into the re-developed Service Accelerator Template based on the review. |
Going to close this for now and reopen when we have a new update to the service accelerator template. |
Pull Request for initial Contribution