Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to docusaurus@2 #358

Closed
akphi opened this issue Mar 12, 2021 · 4 comments
Closed

Upgrade to docusaurus@2 #358

akphi opened this issue Mar 12, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Stale

Comments

@akphi
Copy link
Contributor

akphi commented Mar 12, 2021

We should upgrade to docusaurus@2 for a better layout, support, and performance - https://v2.docusaurus.io/docs/
When we do this, we should also use - slug feature to have our docs homepage changed to https://legend.finos.org/doc, right now that link will throw 404

@akphi akphi self-assigned this Mar 12, 2021
@maoo
Copy link
Member

maoo commented Mar 12, 2021

I like this request, I personally love v2, and use it on http://odp.finos.org/ . That said, v2 is still alpha, and it may be a bit premature to migrate. We could give it a try and see if/what breaks.

Labelling as good first issue.

@maoo maoo added the good first issue Good for newcomers label Mar 12, 2021
@grizzwolf
Copy link
Member

grizzwolf commented Mar 12, 2021

v2 has been in alpha since the middle of 2019 I believe, and they define it as fairly stable.

In banks though, is there any need for IE11 support. I think that would be one of the determining factors (thinking as a web designer). V2 doesn't support IE11 (thankfully for the rest of the internet) but didn't know what type of legacy browsers banks especially might be using.

Also - @maoo is right, whatever custom scripting / css / html was written for the first Legend site will need to be tested. There are slight variations in where / how "parts" are placed in the code. It may not break anything, but...

There are a lot of updated features though that will keep the site modern (and findable from SEO standpoint) in v2, so slight fixes may be a non-issue for the benefits.

@epsstan epsstan added the documentation Improvements or additions to documentation label Mar 19, 2021
@finos-admin
Copy link
Member

This issue is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

@finos-admin
Copy link
Member

This issue was closed because it has been inactive for 35 days. Please re-open if this issue is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

5 participants